Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18738 )

Change subject: IMPALA-9442: Add Ozone to minicluster
......................................................................


Patch Set 13:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/18738/12/java/executor-deps/pom.xml
File java/executor-deps/pom.xml:

http://gerrit.cloudera.org:8080/#/c/18738/12/java/executor-deps/pom.xml@214
PS12, Line 214:       <groupId>org.apache.ozone</groupId>
              :       <artifactId>ozone-filesystem-hadoop3</artifactId>
              :       <version>${ozone.version}</version>
> This difference in the groupId/artifactId will be a problem for the USE_APA
It changed between CDP versions too. I think I'll have to switch this up based 
on minor version.


http://gerrit.cloudera.org:8080/#/c/18738/12/testdata/cluster/admin
File testdata/cluster/admin:

http://gerrit.cloudera.org:8080/#/c/18738/12/testdata/cluster/admin@472
PS12, Line 472:   rm -rf "$IMPALA_CLUSTER_NODES_DIR/$NODE_PREFIX"*/data/ozone
> This is ok. If we find we need it, we can add it later.
Ack


http://gerrit.cloudera.org:8080/#/c/18738/12/testdata/cluster/node_templates/common/etc/hadoop/conf/ozone-site.xml.tmpl
File testdata/cluster/node_templates/common/etc/hadoop/conf/ozone-site.xml.tmpl:

http://gerrit.cloudera.org:8080/#/c/18738/12/testdata/cluster/node_templates/common/etc/hadoop/conf/ozone-site.xml.tmpl@1
PS12, Line 1: <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
> One overarching comment: We added the python-based configurations to be a r
Ozone has a bunch of separate .bind.host keys that default to 0.0.0.0.



--
To view, visit http://gerrit.cloudera.org:8080/18738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b0f7b2d685d8b011df1926e12bf5434b5a2be
Gerrit-Change-Number: 18738
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Wed, 27 Jul 2022 22:11:36 +0000
Gerrit-HasComments: Yes

Reply via email to