Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18616 )
Change subject: IMPALA-10545: Higher data_cache_write_concurrency for SSDs ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/18616/10/be/src/runtime/io/data-cache.cc File be/src/runtime/io/data-cache.cc: http://gerrit.cloudera.org:8080/#/c/18616/10/be/src/runtime/io/data-cache.cc@87 PS10, Line 87: DEFINE_int32(data_cache_write_concurrency, 0, : Substitute("(Advanced) Number of concurrent threads allowed to insert into the cache" : " per partition; unset uses $0 for rotational disks and $1 for solid state disks.", : THREADS_PER_ROTATIONAL_DISK, THREADS_PER_SOLID_STATE_DISK).c_str()); > This test code would access our web UI to check the value of startup option Maybe make the description string a static const like here: https://github.com/apache/impala/blob/master/be/src/runtime/io/disk-io-mgr.cc#L87 -- To view, visit http://gerrit.cloudera.org:8080/18616 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I60761faa2710f4795f1f3eaf66da866b5553f609 Gerrit-Change-Number: 18616 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 28 Jul 2022 16:17:37 +0000 Gerrit-HasComments: Yes
