Xiang Yang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18777 )
Change subject: IMPALA-11454: part-1: use standard binaries path to start kudu test cluster ...................................................................... Patch Set 3: > Patch Set 3: > > > Patch Set 3: > > > > > Patch Set 3: Code-Review+1 > > > > > > This makes sense to me. I think a simpler fix is modifying the toolchain > > > build script to create symlinks pointing to sbin instead of copying > > > binaries directly, as you mentioned in the JIRA: > > > https://github.com/cloudera/native-toolchain/blob/2008e0658c1785ab7a78866e6f46ee6d9214c446/source/kudu/build.sh#L170-L176 > > > > > > Either way is ok for me. I'll see if other reviews have more comments. > > > > Hi quanlong, the symlinks way also can achive the goal that reduce > > toolchain package's size; but when users don't want to use the cdp edition > > kudu, they may meet the lacking of '/bin/kudu-master' problem. > > The symlink is something like 'bin/kudu-master' -> 'sbin/kudu-master'. Why > users will meet the lacking of '/bin/kudu-master' problem? Sorry what I mean of 'cdp edition kudu' is the toolchain builtin kudu. I mean If user don't use native-toolchain build script to build kudu, they may meet the lacking problem. -- To view, visit http://gerrit.cloudera.org:8080/18777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2276ee3e1650532770b856443f1087ad5036dc7a Gerrit-Change-Number: 18777 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Xiang Yang <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 08:07:47 +0000 Gerrit-HasComments: No
