Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18806 )
Change subject: IMPALA-9999: Build the toolchain with GCC 10 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh@313 PS1, Line 313: LIBUNWIND_VERSION=1.5.0-p1 $SOURCE_DIR/source/libunwind/build.sh Why did you skip adding BUILD_HISTORICAL here and for flatbuffers? http://gerrit.cloudera.org:8080/#/c/18806/1/buildall.sh@319 PS1, Line 319: BREAKPAD_VERSION=20150612-p1 $SOURCE_DIR/source/breakpad/build.sh nit: inconsistent indentation -- To view, visit http://gerrit.cloudera.org:8080/18806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fbfcdcb497ad60772bf0a7837e4043ae75bcfaa Gerrit-Change-Number: 18806 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 03 Aug 2022 16:39:08 +0000 Gerrit-HasComments: Yes
