Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18772 )
Change subject: IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs ...................................................................... Patch Set 6: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/18772/5/fe/src/main/java/org/apache/impala/service/JniCatalog.java File fe/src/main/java/org/apache/impala/service/JniCatalog.java: http://gerrit.cloudera.org:8080/#/c/18772/5/fe/src/main/java/org/apache/impala/service/JniCatalog.java@227 PS5, Line 227: Strin > I can try to add more. But some RPCs are easy to get their target. E.g. get Sure, I am ok with the follow up Jira, it could be also a nice ramp-up task for someone new to Impala. If someone touches this area, it could also make sense to create a class hierarchy like CatalogJniOp with the basic common skeleton of this functions http://gerrit.cloudera.org:8080/#/c/18772/5/fe/src/main/java/org/apache/impala/service/JniCatalog.java@261 PS5, Line 261: JniUtil.logResponse(res.length, start, params, "exe > We calculate the duration in JniUtil.logResponse() and add warnings for slo yeah, I think that this can be often useful, e.g. to get a picture of catalog/HMS speed with a simple grep on the log -- To view, visit http://gerrit.cloudera.org:8080/18772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac7f2eda8b95643a3d3c3bef64ea71b67b20595a Gerrit-Change-Number: 18772 Gerrit-PatchSet: 6 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Fri, 05 Aug 2022 10:33:42 +0000 Gerrit-HasComments: Yes
