Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18817 )
Change subject: PROTOTYPE: IMPALA-11207: Use hadoop-cloud-storage for Cloud dependencies ...................................................................... Patch Set 1: Code-Review+1 This seems reasonable. Some of this code is only used at runtime and I'm not sure how good the test coverage is for it. However the fe/target/build-classpath.txt diff between this and just reverting the google-oauth-client change (since this version of hadoop-cloud-storage still uses 0.31) is 34d33 < /home/michael/.m2/repository/com/google/cloud/bigdataoss/gcs-connector/2.1.2.7.2.16.0-77/gcs-connector-2.1.2.7.2.16.0-77.jar 59d57 < /home/michael/.m2/repository/com/jayway/jsonpath/json-path/2.4.0/json-path-2.4.0.jar 144,145d141 < /home/michael/.m2/repository/org/apache/directory/server/apacheds-i18n/2.0.0.AM25/apacheds-i18n-2.0.0.AM25.jar < /home/michael/.m2/repository/org/apache/directory/server/apacheds-jdbm/2.0.0-M5/apacheds-jdbm-2.0.0-M5.jar 150a147 > /home/michael/.m2/repository/org/apache/hadoop/hadoop-cloud-storage/3.1.1.7.2.16.0-77/hadoop-cloud-storage-3.1.1.7.2.16.0-77.jar 226a224,227 > /home/michael/.m2/repository/org/apache/ranger/ranger-raz-hook-abfs/2.1.0.7.2.16.0-77/ranger-raz-hook-abfs-2.1.0.7.2.16.0-77.jar > /home/michael/.m2/repository/org/apache/ranger/ranger-raz-hook-s3/2.1.0.7.2.16.0-77/ranger-raz-hook-s3-2.1.0.7.2.16.0-77.jar > /home/michael/.m2/repository/org/apache/ranger/ranger-raz-intg/2.1.0.7.2.16.0-77/ranger-raz-intg-2.1.0.7.2.16.0-77.jar > /home/michael/.m2/repository/org/apache/ranger/ranger-raz-s3-lib/2.1.0.7.2.16.0-77/ranger-raz-s3-lib-2.1.0.7.2.16.0-77.jar 238,244d238 < /home/michael/.m2/repository/org/codehaus/groovy/groovy/3.0.7/groovy-3.0.7.jar < /home/michael/.m2/repository/org/codehaus/groovy/groovy-console/3.0.7/groovy-console-3.0.7.jar < /home/michael/.m2/repository/org/codehaus/groovy/groovy-groovysh/3.0.7/groovy-groovysh-3.0.7.jar < /home/michael/.m2/repository/org/codehaus/groovy/groovy-json/3.0.7/groovy-json-3.0.7.jar < /home/michael/.m2/repository/org/codehaus/groovy/groovy-swing/3.0.7/groovy-swing-3.0.7.jar < /home/michael/.m2/repository/org/codehaus/groovy/groovy-templates/3.0.7/groovy-templates-3.0.7.jar < /home/michael/.m2/repository/org/codehaus/groovy/groovy-xml/3.0.7/groovy-xml-3.0.7.jar 276d269 < /home/michael/.m2/repository/org/fusesource/jansi/jansi/1.18/jansi-1.18.jar which doesn't seem too concerning. -- To view, visit http://gerrit.cloudera.org:8080/18817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a1631289f990513823c2b17eb9241cc1b5a7ffd Gerrit-Change-Number: 18817 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 05 Aug 2022 22:18:37 +0000 Gerrit-HasComments: No
