Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18816 )
Change subject: IMPALA-11458: Update zlib and zstd ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Thanks for putting this together Small nit about the commit message, but then we're ready to go. (I'll carry the +1 verified from your precommit run, so you wouldn't need to rerun.) http://gerrit.cloudera.org:8080/#/c/18816/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18816/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-11458: Update zlib and zstd : : Updates zlib to 1.2.12 and zstd to 1.5.2. Requires a new toolchain : build. Can you mention the performance testing that we did. Just a couple line summary saying we ran TPC-H with zstd and zlib with no major regressions. -- To view, visit http://gerrit.cloudera.org:8080/18816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96fd5e8c49e581478b249bb8894001457742023 Gerrit-Change-Number: 18816 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 09 Aug 2022 23:17:36 +0000 Gerrit-HasComments: Yes
