Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: IMPALA-9482: Support for BINARY columns ...................................................................... Patch Set 21: (13 comments) http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/main/java/org/apache/impala/analysis/CastExpr.java File fe/src/main/java/org/apache/impala/analysis/CastExpr.java: http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@368 PS21, Line 368: noOp_ = true; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@369 PS21, Line 369: return; tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/main/java/org/apache/impala/analysis/CastExpr.java@370 PS21, Line 370: } tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4278 PS21, Line 4278: "cast(string_col as binary), bool_col, " + tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java File fe/src/test/java/org/apache/impala/catalog/CatalogTest.java: http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@632 PS21, Line 632: // NDV is not calculated for BINARY columns tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/catalog/CatalogTest.java@633 PS21, Line 633: assertFalse(binaryCol.getStats().hasNumDistinctValues()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java File fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java: http://gerrit.cloudera.org:8080/#/c/16066/21/fe/src/test/java/org/apache/impala/catalog/PartialCatalogInfoTest.java@243 PS21, Line 243: stats.get(0).toString()); tab used for whitespace http://gerrit.cloudera.org:8080/#/c/16066/21/tests/hs2/test_fetch.py File tests/hs2/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/16066/21/tests/hs2/test_fetch.py@69 PS21, Line 69: " flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/16066/21/tests/hs2/test_fetch.py@89 PS21, Line 89: " flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/16066/21/tests/hs2/test_fetch.py@100 PS21, Line 100: " flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/16066/21/tests/hs2/test_fetch.py@113 PS21, Line 113: " flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/16066/21/tests/hs2/test_fetch.py@123 PS21, Line 123: " flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/16066/21/tests/query_test/test_udfs.py File tests/query_test/test_udfs.py: http://gerrit.cloudera.org:8080/#/c/16066/21/tests/query_test/test_udfs.py@116 PS21, Line 116: y flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 21 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 11 Aug 2022 09:36:04 +0000 Gerrit-HasComments: Yes
