Tamas Mate has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18819 )

Change subject: IMPALA-11436: Change search bind authentication parameters
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18819/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/18819/1//COMMIT_MSG@11
PS1, Line 11: group searches compared to Spring. This change intends to allign 
these
> typo
Done


http://gerrit.cloudera.org:8080/#/c/18819/1//COMMIT_MSG@14
PS1, Line 14: For user search, Spring uses {0} to replace the login username.
            : Meanwhile, during group search {0} is used to replace the login 
user dn
            : and {1} is used to replace the login username.
> Is this a potentially breaking change? I mean that there can be users who u
Yes, unfortunately this can break running systems, but the identification of 
the problem and fix is more or less straightforward, authentication will fail 
immediately with the new version and config change is enough.

The configurations around ldap are already a bit convoluted, maybe we could 
emphasise this change in the 4.2 release notes?



--
To view, visit http://gerrit.cloudera.org:8080/18819
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9808566a348f7c6200b0571fbc05e67f720f2075
Gerrit-Change-Number: 18819
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
Gerrit-Comment-Date: Thu, 11 Aug 2022 11:52:50 +0000
Gerrit-HasComments: Yes

Reply via email to