Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18850 )
Change subject: IMPALA-11494: Don't always produce Ranger audit log for authorized query ...................................................................... Patch Set 3: (1 comment) lgtm, one comment about code cleanness http://gerrit.cloudera.org:8080/#/c/18850/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java: http://gerrit.cloudera.org:8080/#/c/18850/3/fe/src/main/java/org/apache/impala/authorization/ranger/RangerAuthorizationChecker.java@203 PS3, Line 203: if (authzOk && !analysisOk) auditHandler.getAuthzEvents().clear(); : : // We do not send audit log entries to the Ranger server when authorization succeeded : // but analysis failed. : if (!authzOk || analysisOk) auditHandler.flush(); The two conditions are the opposites of each other - can you convert this to if/else blocks? I think that it would be cleaner. -- To view, visit http://gerrit.cloudera.org:8080/18850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I701652e457d3118f43249e83be933713b17ce48f Gerrit-Change-Number: 18850 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Wed, 17 Aug 2022 09:06:46 +0000 Gerrit-HasComments: Yes
