Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16066 )
Change subject: IMPALA-9482: Support for BINARY columns ...................................................................... Patch Set 24: Code-Review+1 (6 comments) http://gerrit.cloudera.org:8080/#/c/16066/24/be/src/exec/orc-metadata-utils.cc File be/src/exec/orc-metadata-utils.cc: http://gerrit.cloudera.org:8080/#/c/16066/24/be/src/exec/orc-metadata-utils.cc@477 PS24, Line 477: || type.type == TYPE_CHAR) { Could you add a comment about why we don't need TYPE_BINARY here? http://gerrit.cloudera.org:8080/#/c/16066/24/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: http://gerrit.cloudera.org:8080/#/c/16066/24/be/src/runtime/descriptors.h@256 PS24, Line 256: back() nit: front() or [0] seems better (as line 248 uses). Same comment to line 255. http://gerrit.cloudera.org:8080/#/c/16066/24/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java File java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java: http://gerrit.cloudera.org:8080/#/c/16066/24/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@40 PS24, Line 40: import org.apache.hadoop.io.Text; duplicated line http://gerrit.cloudera.org:8080/#/c/16066/24/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@319 PS24, Line 319: String BytesWritable http://gerrit.cloudera.org:8080/#/c/16066/24/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@321 PS24, Line 321: get nit: get() is deprecated by getBytes(). http://gerrit.cloudera.org:8080/#/c/16066/24/java/test-hive-udfs/src/main/java/org/apache/impala/TestGenericUdf.java@326 PS24, Line 326: result nit: handle null 'result' when 'inputs' is empty. -- To view, visit http://gerrit.cloudera.org:8080/16066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I36861a9ca6c2047b0d76862507c86f7f153bc582 Gerrit-Change-Number: 16066 Gerrit-PatchSet: 24 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Aug 2022 02:30:29 +0000 Gerrit-HasComments: Yes
