Hello Quanlong Huang, Joe McDonnell, Impala Public Jenkins, Xiang Yang,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18828
to look at the new patch set (#4).
Change subject: IMPALA-11469: (Addendum) Refactor BackendConfig for tests
......................................................................
IMPALA-11469: (Addendum) Refactor BackendConfig for tests
Moves ignored_dir_prefix_list parsing to BackendConfig creation to avoid
static blocks. The default constructor for TBackendGflags - used in some
tests - leaves the property uninitialized, so guards against nulls.
Adds FrontendTestBase base class to relevant tests to ensure
BackendConfig is set.
Failure to initialize BackendConfig meant that test success would depend
on their order. If FileSystemUtilTest or another test that initialized
it were the first to use FileSystemUtil, then everything would pass. If
not, the static declaration in FileSystemUtil would fail, causing the
class to fail to be loaded. Later tests would fail with NoClassDefFound
errors.
Testing:
- Ran frontend tests individually.
Change-Id: I802fcbf70808f2127197f720a7247c3d85389d6f
---
M fe/src/main/java/org/apache/impala/common/FileSystemUtil.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M fe/src/test/java/org/apache/impala/catalog/FileMetadataLoaderTest.java
M fe/src/test/java/org/apache/impala/common/FileSystemUtilTest.java
4 files changed, 30 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/18828/4
--
To view, visit http://gerrit.cloudera.org:8080/18828
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I802fcbf70808f2127197f720a7247c3d85389d6f
Gerrit-Change-Number: 18828
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Xiang Yang <[email protected]>
