Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18736 )
Change subject: IMPALA-10918: Allow map type in SELECT list ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/18736/9/fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java: http://gerrit.cloudera.org:8080/#/c/18736/9/fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java@a124 PS9, Line 124: Is this supported now, or just the error message changes? http://gerrit.cloudera.org:8080/#/c/18736/9/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/18736/9/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test@14 PS9, Line 14: string I just realized the return type of MAP is STRING. Is it also the result of typeof(int_map)? I'm just curious how far we are to support casting MAP to STRING and using it in get_json_object() func, e.g. select id, get_json_object(int_map, '$.k2') from complextypestbl http://gerrit.cloudera.org:8080/#/c/18736/9/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test@310 PS9, Line 310: select id, map_1d, map_2d, map_3d, arr_int_3d, map_map_array from collection_tbl; It seems only this query is using 'collection_tbl' for testing MAP support. Can we add more cases? E.g. select id, map_1d, map_2d, mma.value, ma.value from collection_tbl c, c.map_map_array mma, mma.value ma; -- To view, visit http://gerrit.cloudera.org:8080/18736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I921c647f1779add36e7f5df4ce6ca237dcfaf001 Gerrit-Change-Number: 18736 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 16 Aug 2022 13:30:54 +0000 Gerrit-HasComments: Yes
