Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality ...................................................................... Patch Set 1: (4 comments) Thank you for the review Andrew and Gergely. Updated the change. http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml File docs/topics/impala_iceberg.xml: http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@513 PS1, Line 513: Iceberg snapshots accumulate until they are expired > This does not feel quite right. It suggests that the accumulation stops on Done http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@525 PS1, Line 525: <li>does not remove orphanned data files.</li> > Spelling: "orphaned" Done http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526 PS1, Line 526: minumum snapshots > I think minimum should refer to the quantity in this case Done http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526 PS1, Line 526: <li>respects the minumum snapshots to keep: > Spelling: "minimum" Done -- To view, visit http://gerrit.cloudera.org:8080/18838 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836 Gerrit-Change-Number: 18838 Gerrit-PatchSet: 1 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 Aug 2022 11:15:23 +0000 Gerrit-HasComments: Yes
