Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18134 )
Change subject: IMPALA-9999: Switch to GCC 10.4 ...................................................................... Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/18134/10/be/src/runtime/string-value.inline.h File be/src/runtime/string-value.inline.h: http://gerrit.cloudera.org:8080/#/c/18134/10/be/src/runtime/string-value.inline.h@41 PS10, Line 41: // GCC gives a warning about overflowing the size argument of memcmp, because > The int type is coming from StringValue/StringVal's len field. These are us I like using len <= 0 to cover it. -- To view, visit http://gerrit.cloudera.org:8080/18134 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe6857b822925226d39fd4d6413457ef6bbaabec Gerrit-Change-Number: 18134 Gerrit-PatchSet: 11 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 18 Aug 2022 05:26:51 +0000 Gerrit-HasComments: Yes
