[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/18854 )
Change subject: IMPALA-11500: Fix Impalad crashed in ParquetBoolDecoder::SkipValues when num_values is 0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18854/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-11500: F > nit: you shouldn't use brackets, first line should be: That is my mistakes! Subconsciously using the style of the company I work for. http://gerrit.cloudera.org:8080/#/c/18854/1/be/src/exec/parquet/parquet-column-readers.cc File be/src/exec/parquet/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/18854/1/be/src/exec/parquet/parquet-column-readers.cc@396 PS1, Line 396: if (bool_decoder_) { > Maybe the solution can be made a bit more future-proof if we make the bool Done -- To view, visit http://gerrit.cloudera.org:8080/18854 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4c5a4dff9e9e75913c7b524b4ae70967febb37 Gerrit-Change-Number: 18854 Gerrit-PatchSet: 2 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 18 Aug 2022 02:58:21 +0000 Gerrit-HasComments: Yes
