Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/18711 )
Change subject: IMPALA-11418: The only select constant statement need not to spool results ...................................................................... Patch Set 4: (3 comments) Thank you for working on this! The change makes sense to me. I only have few nits. http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@474 PS4, Line 474: The statement only select constant need not to spool query results. nit: A statement that only selects constant does not need to spool query results. http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@480 PS4, Line 480: clientRequest.query_options.setSpool_query_results(false); Can you add LOG.trace here? Like what we have in: https://github.com/apache/impala/blob/f1420ae51b2e00ad093be64a0d2135ca36aa6514/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java#L101-L105 http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/18711/4/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@1705 PS4, Line 1705: * Check if the select statement only select constant Can you add two example query in this method documentation for both case? - Select constant - Select constant from InlineView -- To view, visit http://gerrit.cloudera.org:8080/18711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icd4d73c21106048df68a270cf03d4abd56bd3aac Gerrit-Change-Number: 18711 Gerrit-PatchSet: 4 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Sun, 21 Aug 2022 02:42:50 +0000 Gerrit-HasComments: Yes
