Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18316 )
Change subject: IMPALA-10069: Support TLS 1.3 ciphersuites ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18316/4/be/src/rpc/rpc-mgr.cc File be/src/rpc/rpc-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18316/4/be/src/rpc/rpc-mgr.cc@181 PS4, Line 181: bld.set_rpc_tls_ciphersuites(FLAGS_tls_ciphersuites); > Do we need to call bld.set_rpc_tls_ciphersuites() if FLAGS_tls_ciphersuites We don't need the call if it is the same as kDefaultTlsCipherSuites, but it also doesn't change the behavior one way or the other. http://gerrit.cloudera.org:8080/#/c/18316/4/be/src/rpc/rpc-mgr.cc@184 PS4, Line 184: == "" > Should we use .empty()? Good point, switched this over http://gerrit.cloudera.org:8080/#/c/18316/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/18316/4/be/src/service/impala-server.cc@248 PS4, Line 248: Thrift RPC > Thrift RPC and KRPC? Good point, changed this -- To view, visit http://gerrit.cloudera.org:8080/18316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6974dae7fb429599847165614adc4eaaf338f744 Gerrit-Change-Number: 18316 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 22 Aug 2022 20:24:54 +0000 Gerrit-HasComments: Yes
