Hello Wenzhe Zhou, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18889
to review the following change.
Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with
result caching
......................................................................
IMPALA-11447: Fix crash when fetching arrays/structs with result caching
Some parts of HS2ColumnarResultSet were not prepared for returning
non-scalar types. This code only runs if impala.resultset.cache.size
is set, which is not the case in most of tests. The issue was caught
with Hue, which uses result caching.
Testing:
- Added a regression test in test_fetch_first.py, which contained
other tests that used result caching.
- It turned out that some tests in the file did not run at all,
as @needs_session() needs the parenthesis at the end. For this
reason some test fixes were added to run them correctly, though
these changes are totally unrelated to the current issue.
Backport issue:
- Test fails due to STRUCT in SelectList not supported on Parquet.
Changed to use the corresponding ORC table.
Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Reviewed-on: http://gerrit.cloudera.org:8080/18768
Reviewed-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Wenzhe Zhou <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M be/src/service/query-result-set.cc
M tests/hs2/test_fetch_first.py
2 files changed, 49 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/18889/1
--
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
