Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18910 )
Change subject: IMPALA-11525: Rename Exec libraries to avoid conflicts with external libraries ...................................................................... Patch Set 2: Thanks for putting this together! One other small thing: Since some IR files moved to a different library, I think we also should update be/src/codegen/CMakeLists.txt. This location refers to Exec, but I think it now needs to refer to ExecAvro and ExecKudu as well: https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L88 https://github.com/apache/impala/blob/master/be/src/codegen/CMakeLists.txt#L98 -- To view, visit http://gerrit.cloudera.org:8080/18910 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I042478e371049a7aed74f43c2bbfcb7900a53dd0 Gerrit-Change-Number: 18910 Gerrit-PatchSet: 2 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Fri, 26 Aug 2022 16:23:10 +0000 Gerrit-HasComments: No
