Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18909 )
Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/18909/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18909/2//COMMIT_MSG@21 PS2, Line 21: > Remove TODO? Ooops, some leftover :) Done http://gerrit.cloudera.org:8080/#/c/18909/2/be/src/exec/orc/hdfs-orc-scanner.cc File be/src/exec/orc/hdfs-orc-scanner.cc: http://gerrit.cloudera.org:8080/#/c/18909/2/be/src/exec/orc/hdfs-orc-scanner.cc@606 PS2, Line 606: file_position_ = slot > nit: maybe we should rename this variable to 'file_position_' Done http://gerrit.cloudera.org:8080/#/c/18909/2/tests/query_test/test_scanners.py File tests/query_test/test_scanners.py: http://gerrit.cloudera.org:8080/#/c/18909/2/tests/query_test/test_scanners.py@161 PS2, Line 161: especially ORC > Would be nice if we could add some tests here as well. Agree, but the underlying .test file uses tables that only exist in Parquet. I figured I'd save the hassle of creating them to ORC as well. I did some manual experimenting based on the tests in mixing-virtual-columns.test to verify that I get the same results between functional_parquet and functional_orc_def. -- To view, visit http://gerrit.cloudera.org:8080/18909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Gerrit-Change-Number: 18909 Gerrit-PatchSet: 3 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 29 Aug 2022 12:36:17 +0000 Gerrit-HasComments: Yes
