Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 )
Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18853/5//COMMIT_MSG@10 PS5, Line 10: Updates : file handle cache enablement to be more stringent about enabling : caching. > Nit: I think this addresses IMPALA-10375, so we can modify the language her Done http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py File tests/custom_cluster/test_hdfs_fd_caching.py: http://gerrit.cloudera.org:8080/#/c/18853/5/tests/custom_cluster/test_hdfs_fd_caching.py@182 PS5, Line 182: --cache_remote_file_handles > If max_cached_file_handles=0, caching can't happen (is_file_handle_caching_ I don't remember why I included max_cached_file_handles here. Separate tests for each flag disabled with remote storage makes sense to me. -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 29 Aug 2022 21:22:40 +0000 Gerrit-HasComments: Yes
