Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18916 )
Change subject: IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs ...................................................................... IMPALA-11401,IMPALA-10794: Add logs and thread names for catalogd RPCs We've seen catalogd throws OutOfMemoryError when serializing large responses (i.e. size > 2GB). However, the related table names are missing in the logs. Admins would like to get the table names and blacklist those tables until they are optimized (e.g. reducing partitions). To improve the supportability, this patch adds logs in the Catalogd RPC code paths to log some details of the request, also add thread annotations to improve readability of jstacks. Tests: - Add unit tests for short descriptions of requests. - Manually add codes to throw OutOfMemoryError and verify the logs shown as expected. - Run test_concurrent_ddls.py and metadata tests. Capture jstacks and verify the thread annotations are shown. - Run CORE tests Change-Id: Iac7f2eda8b95643a3d3c3bef64ea71b67b20595a Reviewed-on: http://gerrit.cloudera.org:8080/18772 Reviewed-by: Csaba Ringhofer <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> Reviewed-on: http://gerrit.cloudera.org:8080/18916 Tested-by: Quanlong Huang <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/ColumnName.java M fe/src/main/java/org/apache/impala/analysis/FunctionName.java M fe/src/main/java/org/apache/impala/analysis/ResetMetadataStmt.java M fe/src/main/java/org/apache/impala/analysis/TableName.java M fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/JniCatalog.java A fe/src/main/java/org/apache/impala/util/CatalogOpUtil.java A fe/src/test/java/org/apache/impala/util/CatalogOpUtilTest.java 9 files changed, 513 insertions(+), 36 deletions(-) Approvals: Quanlong Huang: Verified Csaba Ringhofer: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/18916 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-4.1.1 Gerrit-MessageType: merged Gerrit-Change-Id: Iac7f2eda8b95643a3d3c3bef64ea71b67b20595a Gerrit-Change-Number: 18916 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]>
