Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 )
Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables ...................................................................... Patch Set 8: (6 comments) Sorry for being this late to the review. I did a quick go through and left some minor comments. http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java File fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@572 PS7, Line 572: Iceberg DataFile nit: This is not just for dataFiles anymore, right? http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@579 PS7, Line 579: getDataFilePathHash nit: same as above: this is for deleteFiles as well, right? http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@683 PS7, Line 683: */ Could you please add a comment that with travelSpec=null the current snapshot is going to be used? http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@692 PS7, Line 692: long totalDeleteFiles = Long.parseLong(totalDeleteFilesStr); Don't you need a try-catch block similarly to L699-706? http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java@718 PS7, Line 718: if (snapshot == null) { return null; } nit: curly brackets are not needed here. http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/18847/7/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@558 PS7, Line 558: for (DeleteFile delFile : scanTask.deletes()) { I think instead of this for loop you can use Set.addAll(). -- To view, visit http://gerrit.cloudera.org:8080/18847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672cfee18d8e131772d90378d5b12ad4d0f7dd48 Gerrit-Change-Number: 18847 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 12:52:19 +0000 Gerrit-HasComments: Yes
