Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/18853 )
Change subject: IMPALA-10214, IMPALA-10375: Ozone remote file handle caching ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/18853/9/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/18853/9/be/src/runtime/io/scan-range.cc@175 PS9, Line 175: if (is_file_handle_caching_enabled() && ( : (expected_local_ && IsHdfsPath(file())) || : (FLAGS_cache_remote_file_handles && disk_id_ == io_mgr_->RemoteDfsDiskId()) || : (FLAGS_cache_ozone_file_handles && ( : (expected_local_ && IsOzonePath(file())) || : (disk_id_ == io_mgr_->RemoteOzoneDiskId()))) || : (FLAGS_cache_s3_file_handles && disk_id_ == io_mgr_->RemoteS3DiskId()) || : (FLAGS_cache_abfs_file_handles && disk_id_ == io_mgr_->RemoteAbfsDiskId()))) { : use_file_handle_cache = true; : } > Optional: extract this to a new functions? Maybe a separate function for each filesystem? -- To view, visit http://gerrit.cloudera.org:8080/18853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9df13208999c6d3b14f4c005a91ee2a92a05bdf9 Gerrit-Change-Number: 18853 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 15:51:29 +0000 Gerrit-HasComments: Yes
