Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18909 )
Change subject: IMPALA-11529: FILE__POSITION virtual column for ORC tables ...................................................................... IMPALA-11529: FILE__POSITION virtual column for ORC tables IMPALA-11350 implemented the FILE__POSITION virtual column for Parquet files. This ticket does the same but for ORC files. Note, that for full ACID ORC tables there have already been an implementation of row__id that could simply be re-used for this ticket. Testing: - TestScannersVirtualColumns.test_virtual_column_file_position_generic is changed to run now on ORC as well. I don't think further testing is required as this functionality has already been there for row__id we just re-used it for FILE__POSITION. Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Reviewed-on: http://gerrit.cloudera.org:8080/18909 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/hdfs-scanner.cc M be/src/exec/orc/hdfs-orc-scanner.cc M be/src/exec/orc/hdfs-orc-scanner.h M be/src/exec/orc/orc-column-readers.cc M be/src/exec/orc/orc-column-readers.h M testdata/workloads/functional-query/queries/QueryTest/virtual-column-file-position-generic.test M tests/query_test/test_scanners.py 7 files changed, 35 insertions(+), 25 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/18909 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie8e951f73ceb910d64cd149192853a4a2131f79b Gerrit-Change-Number: 18909 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
