Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18894 )
Change subject: IMPALA-11507: Use absolute_path when Iceberg data files outside of the table location ...................................................................... Patch Set 6: (4 comments) Thanks for working on this! Looks great, only left a few minor comments. http://gerrit.cloudera.org:8080/#/c/18894/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18894/6//COMMIT_MSG@7 PS6, Line 7: files outside nit: files are outside http://gerrit.cloudera.org:8080/#/c/18894/6/common/fbs/CatalogObjects.fbs File common/fbs/CatalogObjects.fbs: http://gerrit.cloudera.org:8080/#/c/18894/6/common/fbs/CatalogObjects.fbs@83 PS6, Line 83: files outside nit: files are outside http://gerrit.cloudera.org:8080/#/c/18894/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/18894/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@240 PS6, Line 240: StringUtils.EMPTY Does an empty string occupies space in the flat buffer object? If yes, maybe we could try to avoid creating the strings. http://gerrit.cloudera.org:8080/#/c/18894/6/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@331 PS6, Line 331: .add("absolutePath", getAbsolutePath() Maybe only add this when 'absolutePath' is not null. nit: it should be 'AbsolutePath' (capital A) to follow the namings of the other fields. -- To view, visit http://gerrit.cloudera.org:8080/18894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I666bed21d20d5895f4332e92eb30a94fa24250be Gerrit-Change-Number: 18894 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 30 Aug 2022 16:44:13 +0000 Gerrit-HasComments: Yes
