Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/18930 )
Change subject: IMPALA-11543: Print exception message even if throwable_to_stack_trace_id fails ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18930/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18930/2//COMMIT_MSG@9 PS2, Line 9: Nit: if we got http://gerrit.cloudera.org:8080/#/c/18930/2/be/src/util/jni-util.cc File be/src/util/jni-util.cc: http://gerrit.cloudera.org:8080/#/c/18930/2/be/src/util/jni-util.cc@282 PS2, Line 282: msg_str_guard.get() != nullptr I think it can be turned into a DCHECK because if it is nullptr, JniUtfCharGuard::create() returns with an error status on L274. -- To view, visit http://gerrit.cloudera.org:8080/18930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d08abb685e687170fc4f3d7a0e38e6c5cae09c Gerrit-Change-Number: 18930 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 31 Aug 2022 08:21:18 +0000 Gerrit-HasComments: Yes
