Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18847 )
Change subject: IMPALA-11484: Create SCAN plan for Iceberg V2 position delete tables ...................................................................... Patch Set 10: (3 comments) Thanks for the comments. http://gerrit.cloudera.org:8080/#/c/18847/10/testdata/datasets/functional/schema_constraints.csv File testdata/datasets/functional/schema_constraints.csv: http://gerrit.cloudera.org:8080/#/c/18847/10/testdata/datasets/functional/schema_constraints.csv@86 PS10, Line 86: table_format:parquet/none/none > Is the table_format correct for these new ORC backed Iceberg tables? Yes, we currently put every table to the functional_parquet database. It would be nice to separate them to ORC, or creating a new functional_iceberg_parquet/orc database, but the data loading job and current test dimensions don't really support this. http://gerrit.cloudera.org:8080/#/c/18847/10/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test: http://gerrit.cloudera.org:8080/#/c/18847/10/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test@3 PS10, Line 3: iceberg_v2_no_deletes_orc > Could you please add some info about these new tables into a README? e.g. h Done http://gerrit.cloudera.org:8080/#/c/18847/10/testdata/workloads/functional-query/queries/QueryTest/iceberg-v2-read-position-deletes-orc.test@9 PS10, Line 9: aggregation(SUM, NumRowGroups): 0aggregation(SUM, NumFileMetadataRead): 0 > nit: break line in the middle? Done -- To view, visit http://gerrit.cloudera.org:8080/18847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I672cfee18d8e131772d90378d5b12ad4d0f7dd48 Gerrit-Change-Number: 18847 Gerrit-PatchSet: 10 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 31 Aug 2022 16:32:33 +0000 Gerrit-HasComments: Yes
