Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18736 )
Change subject: IMPALA-10918: Allow map type in SELECT list ...................................................................... Patch Set 13: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/18736/9/fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java: http://gerrit.cloudera.org:8080/#/c/18736/9/fe/src/test/java/org/apache/impala/analysis/AnalyzeUpsertStmtTest.java@a124 PS9, Line 124: > Just the message changes, but it returns an error like the one on L76, so i Ack http://gerrit.cloudera.org:8080/#/c/18736/13/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test File testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test: http://gerrit.cloudera.org:8080/#/c/18736/13/testdata/workloads/functional-query/queries/QueryTest/nested-map-in-select-list.test@178 PS13, Line 178: array nit: map http://gerrit.cloudera.org:8080/#/c/18736/13/tests/query_test/test_nested_types.py File tests/query_test/test_nested_types.py: http://gerrit.cloudera.org:8080/#/c/18736/13/tests/query_test/test_nested_types.py@180 PS13, Line 180: class TestNestedMapsInSelectList(ImpalaTestSuite): Can we merge this into the above class? It seems their test_dimensions are the same. -- To view, visit http://gerrit.cloudera.org:8080/18736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I921c647f1779add36e7f5df4ce6ca237dcfaf001 Gerrit-Change-Number: 18736 Gerrit-PatchSet: 13 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 06 Sep 2022 03:54:09 +0000 Gerrit-HasComments: Yes
