Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18933 )
Change subject: IMPALA-11159: Fix AttributeError in TestAsyncDDLTiming.test_ctas ...................................................................... Patch Set 2: (2 comments) Thank you for the review Quanlong, Csaba. Updated the patch. http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py@1151 PS2, Line 1151: _last_operation_string > nit: It seems better to use query_string() instead of the internal field "_ Done http://gerrit.cloudera.org:8080/#/c/18933/2/tests/common/impala_test_suite.py@1152 PS2, Line 1152: else: > nit: might be safer to check hasattr(handle.get_handle(), 'id'): as well Done -- To view, visit http://gerrit.cloudera.org:8080/18933 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe78b3a3ee070a1edeaef5cf7ae8d9565a10141d Gerrit-Change-Number: 18933 Gerrit-PatchSet: 2 Gerrit-Owner: Tamas Mate <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 06 Sep 2022 12:00:32 +0000 Gerrit-HasComments: Yes
