Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/18918 )
Change subject: IMPALA-11226: Add script to simplify resolving minidumps ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18918/1/bin/resolve_minidumps.py File bin/resolve_minidumps.py: http://gerrit.cloudera.org:8080/#/c/18918/1/bin/resolve_minidumps.py@149 PS1, Line 149: not breakpad_version: > return None if breakpad_version is None? Good point, done http://gerrit.cloudera.org:8080/#/c/18918/1/bin/resolve_minidumps.py@181 PS1, Line 181: > Should we check if dump_syms is None since find_breakpad_binary() could ret Changed up the code to check the existence of the binary before calling this (and other functions that need Breakpad binaries). -- To view, visit http://gerrit.cloudera.org:8080/18918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0f8fdcb8ca89d0904dc8ec69337e3d5dfdd54adf Gerrit-Change-Number: 18918 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Wed, 07 Sep 2022 00:44:09 +0000 Gerrit-HasComments: Yes
