Xianqing He has posted comments on this change. ( http://gerrit.cloudera.org:8080/18960 )
Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18960/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue > nit: add space Done http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h File be/src/runtime/blocking-row-batch-queue.h: http://gerrit.cloudera.org:8080/#/c/18960/1/be/src/runtime/blocking-row-batch-queue.h@112 PS1, Line 112: std::unique_ptr > optional: Can't we use BlockingQueue directly as member without ptr/unique_ Yes, I think we can. But that requires more changes, we should change '->' to '.' -- To view, visit http://gerrit.cloudera.org:8080/18960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56 Gerrit-Change-Number: 18960 Gerrit-PatchSet: 2 Gerrit-Owner: Xianqing He <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sahil Takiar <[email protected]> Gerrit-Reviewer: Xianqing He <[email protected]> Gerrit-Comment-Date: Tue, 13 Sep 2022 03:35:02 +0000 Gerrit-HasComments: Yes
