Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18824 )
Change subject: IMPALA-11477: Adding Codegen to sorted-run-merger ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/18824/4/be/src/runtime/sorted-run-merger.cc File be/src/runtime/sorted-run-merger.cc: http://gerrit.cloudera.org:8080/#/c/18824/4/be/src/runtime/sorted-run-merger.cc@30 PS4, Line 30: SortedRunMerger::SortedRunWrapper::SortedRunWrapper(SortedRunMerger* parent, const RunBatchSupplierFn& sorted_run) line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/18824/4/be/src/runtime/sorted-run-merger.cc@169 PS4, Line 169: llvm::Function* fn = codegen->GetFunction(IRFunction::SORTED_RUN_MERGER_HEAPIFY_HELPER, true); line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic35c7460bdbd54b8ec5872a83680e2f41ceae9fd Gerrit-Change-Number: 18824 Gerrit-PatchSet: 4 Gerrit-Owner: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Comment-Date: Wed, 14 Sep 2022 16:45:32 +0000 Gerrit-HasComments: Yes
