Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18978 )
Change subject: IMPALA-11580: Fix memory leak in legacy catalog mode when applying incremental partition updates ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/18978/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18978/1//COMMIT_MSG@13 PS1, Line 13: reference to the old table object remains unchanged > Can't this also cause bugs? Or while the new / old table are different obje It should cause bugs in theory. But we are lucky that for unpartitioned tables, we don't have this issue. For partitioned tables, the usages in impalad side don't depend on any changable fields, e.g. most of the usages are on getting the partition columns which can't change. https://github.com/apache/impala/blob/3e06d600c2dcb2c9bcdc4f52cd27cd5d180a900b/fe/src/main/java/org/apache/impala/analysis/AlterTableAlterColStmt.java#L118-L120 -- To view, visit http://gerrit.cloudera.org:8080/18978 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie04ff243c6b82c1a06c489da74353f2d8afe423a Gerrit-Change-Number: 18978 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 15 Sep 2022 00:07:24 +0000 Gerrit-HasComments: Yes
