Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18940 )
Change subject: IMPALA-11420: Support CREATE/ALTER VIEW SET/UNSET TBLPROPERTIES ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/18940/6/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java File fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java: http://gerrit.cloudera.org:8080/#/c/18940/6/fe/src/main/java/org/apache/impala/analysis/AlterViewSetTblProperties.java@73 PS6, Line 73: "ALTER VIEW not allowed on a table: %s", tableName_)); This will confuse the user if the view is a materialized view. From the user's perspective, MV is not a table although we treat it as a table internally. We can check whether 'tableRef' is a MaterializedViewHdfsTable and use another error message, e.g. ALTER VIEW SET TBLPROPERTIES not supported on materialized view. -- To view, visit http://gerrit.cloudera.org:8080/18940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d05bb4ec1f70f5387bb21fbe23f62c05941af18 Gerrit-Change-Number: 18940 Gerrit-PatchSet: 6 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 15 Sep 2022 02:36:13 +0000 Gerrit-HasComments: Yes
