Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19009 )
Change subject: IMPALA-11342: Fix class loading in Hive UDFs' constructors ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/19009/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19009/1//COMMIT_MSG@24 PS1, Line 24: Merge conflicts in branch-4.1: : - HiveJavaFunctionFactoryImpl.java ignores the case for GenericUDF : - Ignores changes in GenericImportsNearbyClassesUdf.java > Do I understand correctly that 4.1.1 does not contain IMPALA-11162: "Suppor Sorry, I realized that I was wrong - I only remembered that instantiation in catalogd is not needed for legacy UDFs, but the code actually instantiates it since https://github.com/apache/impala/commit/4734a681f3780a947dfe998f78f8b358e2f422ca So this issue can come up legacy UDFs too since the refactor above, making this fix useful (and probably less risky than reverting the refactor) -- To view, visit http://gerrit.cloudera.org:8080/19009 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: branch-4.1.1 Gerrit-MessageType: comment Gerrit-Change-Id: If16e38b8fc3b2577a5d32104ea9e6948b9562e24 Gerrit-Change-Number: 19009 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 19 Sep 2022 06:16:04 +0000 Gerrit-HasComments: Yes
