Hello Tamas Mate, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19019
to review the following change.
Change subject: IMPALA-11528: Catalogd should start up with a corrupt Hive
function.
......................................................................
IMPALA-11528: Catalogd should start up with a corrupt Hive function.
This commit handles the case for a specific kind of corrupt function
within the Hive Metastore in the following situation:
A valid Hive SQL function gets created in HMS. This UDF is written in
Java and must derive from the "UDF" class. After creating this function
in Impala, we then replace the underlying jar file with a class that
does NOT derive from the "UDF" class.
In this scenario, catalogd should reject the function and still start
up gracefully. Before this commit, catalogd wasn't coming up. The
reason for this was because the Hive function
FunctionUtils.getUDFClassType() has a dependency on UDAF and was
throwing a LinkageError exception, so we need to include the UDAF
class in the shaded jar.
Merge conflicts in branch-4.1:
- Ignored MapredContext.class in java/shaded-deps/hive-exec/pom.xml
Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
Reviewed-on: http://gerrit.cloudera.org:8080/18927
Tested-by: Impala Public Jenkins <[email protected]>
Reviewed-by: Tamas Mate <[email protected]>
---
M fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
M java/pom.xml
M java/shaded-deps/hive-exec/pom.xml
A java/test-corrupt-hive-udfs/pom.xml
A java/test-corrupt-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
A java/test-hive-udfs/src/main/java/org/apache/impala/CorruptUdf.java
M testdata/bin/copy-udfs-udas.sh
M tests/custom_cluster/test_permanent_udfs.py
8 files changed, 153 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/19/19019/1
--
To view, visit http://gerrit.cloudera.org:8080/19019
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: I54e7a1df6d018ba6cf5ecf32dc9946edf86e2112
Gerrit-Change-Number: 19019
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Tamas Mate <[email protected]>
