Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18995 )
Change subject: IMPALA-11583: Use Iceberg API to update stats ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test: http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@77 PS4, Line 77: row_regex:'','impala.lastComputeStatsTime','\d+\s+' I am not sure which operation sets this property - can you unset it before executing compute incremental stat? http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@86 PS4, Line 86: ALTER TABLE ice_alltypes : SET TBLPROPERTIES('numRows'='1000', 'STATS_GENERATED_VIA_STATS_TASK'='true'); Shouldn't we deny this operation, or at least return a warning? http://gerrit.cloudera.org:8080/#/c/18995/4/testdata/workloads/functional-query/queries/QueryTest/iceberg-compute-stats.test@111 PS4, Line 111: ==== Can you also add a drop stats statement? -- To view, visit http://gerrit.cloudera.org:8080/18995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b6e0a5a65e18e5aaf2a007ec0242b28e0fed92 Gerrit-Change-Number: 18995 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 19 Sep 2022 15:43:58 +0000 Gerrit-HasComments: Yes
