Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19020 )
Change subject: IMPALA-11160: Ignore stale ALTER_PARTITION events on transactional tables ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/19020/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19020/1//COMMIT_MSG@25 PS1, Line 25: Tests The solution looks good, but one thing bugs me: shouldn't the original bug lead to other issues than the incremental stats one? Maybe it would make sense to add other regression tests where the table is recreated with the same name, and this is done in a loop several time, not just once to avoid flakyness. This should have been caught by an event processing test instead of one about ACID + COMPUTE STATS. I am ok with a follow up Jira instead of adding more tests in this one. -- To view, visit http://gerrit.cloudera.org:8080/19020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bb8cfc213093f3bbd0359c7084b277a3bd5264a Gerrit-Change-Number: 19020 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Tue, 20 Sep 2022 04:53:57 +0000 Gerrit-HasComments: Yes
