wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/18829 )
Change subject: IMPALA-7942 (part 1): Add query hints for table cardinalities ...................................................................... Patch Set 8: (2 comments) I found that when executing test, the cardinality of functional_parquet.alltypes seems different in each jenkins test. Refer to: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17575/testReport/junit/org.apache.impala.planner/PlannerTest/testTableCardinalityHint/ Besides, I found that cardinality of functional_parquet.alltypes are different in test file, such as: mt-dop-validation.test, parquet-filtering.test, parquet-stats-agg.test. Since these test cases not use VALIDATE_CARDINALITY. But this seems not happen to functional.alltypes, why? http://gerrit.cloudera.org:8080/#/c/18829/5/fe/src/main/java/org/apache/impala/analysis/TableRef.java File fe/src/main/java/org/apache/impala/analysis/TableRef.java: http://gerrit.cloudera.org:8080/#/c/18829/5/fe/src/main/java/org/apache/impala/analysis/TableRef.java@176 PS5, Line 176: tableNumRowsHint_ > IMHO, that the table references are in different scope should not matter, a Thanks for suggestion, Qifan. I try this may, but find a problem. We can add a static map to reserve each involved table and related row hint. Bug when do we clean this map? If we do not clean this map, when submit same query second time, this map already contains involved table in first submit and not been clean. Then second submit will invalid rows hint. We need to clean this map after sql parse complete, but it seem that we don't know when does sql parse end in TableRef.java http://gerrit.cloudera.org:8080/#/c/18829/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/18829/6/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@5046 PS6, Line 5046: Syntax error in line 1 > Sure. Your current code and the test are good. Done -- To view, visit http://gerrit.cloudera.org:8080/18829 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9f0c773f4e67782a1428db64062f68afbd257af7 Gerrit-Change-Number: 18829 Gerrit-PatchSet: 8 Gerrit-Owner: wangsheng <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fucun Chu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 20 Sep 2022 08:26:39 +0000 Gerrit-HasComments: Yes
