Jian Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19021 )
Change subject: IMPALA-11555: external Udf support decimal(*, *) ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19021/3/fe/src/main/java/org/apache/impala/catalog/ScalarType.java File fe/src/main/java/org/apache/impala/catalog/ScalarType.java: http://gerrit.cloudera.org:8080/#/c/19021/3/fe/src/main/java/org/apache/impala/catalog/ScalarType.java@a118 PS3, Line 118: why remove this pre-condition? will these values be negative? -- To view, visit http://gerrit.cloudera.org:8080/19021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09f19da5b1660ed0b882497fc321e6cc1b9b55d0 Gerrit-Change-Number: 19021 Gerrit-PatchSet: 3 Gerrit-Owner: Minghui Zhu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Comment-Date: Thu, 22 Sep 2022 03:45:58 +0000 Gerrit-HasComments: Yes
