Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18995 )
Change subject: IMPALA-11583: Use Iceberg API to update stats ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/18995/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/18995/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@4498 PS7, Line 4498: try { : tryWriteLock(table, reason); : long newCatalogVersion = catalog_.incrementAndGetCatalogVersion(); : catalog_.getLock().writeLock().unlock(); : This doesn't look good, the code was recently added in https://gerrit.cloudera.org/#/c/19020/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java -- To view, visit http://gerrit.cloudera.org:8080/18995 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46b6e0a5a65e18e5aaf2a007ec0242b28e0fed92 Gerrit-Change-Number: 18995 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gergely Fürnstáhl <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 22 Sep 2022 13:27:01 +0000 Gerrit-HasComments: Yes
