Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18456 )
Change subject: WIP bump impyla dependency to 0.18a6 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/18456/3/bin/impala-config.sh@186 PS3, Line 186: export IMPALA_THRIFT_PY_VERSION=0.16.0-p3 > In shell/packaging/requirements.txt, we set Thrift PY version as 0.16.0. Sh The reason for using this is that IMPALA_THRIFT_PY_VERSION is used during the .thrift->py compilation, so it referes to a cpp code generation library, not the python Thrift module itself. So we use the same library as with other languages. The same is done for Java, it uses 0.16.0-p3 compiler with vanilla 0.16.0 java library. Note that our 0.16.0-p3 Thrift only contains c++ related patches: https://github.com/cloudera/native-toolchain/tree/ma ster/source/thrift/thrift-0.16.0-patches So we could use 0.16.0 instead and generate the same results, but it is more convenient to reuse the same version as in cpp. -- To view, visit http://gerrit.cloudera.org:8080/18456 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7265558b0e07959c606cba73cd251c3edfcb3ed5 Gerrit-Change-Number: 18456 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 23 Sep 2022 05:37:26 +0000 Gerrit-HasComments: Yes
