Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19001 )
Change subject: IMPALA-11562: Revert support for o3fs as default filesystem ...................................................................... Patch Set 4: (12 comments) http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/load-test-warehouse-snapshot.sh File testdata/bin/load-test-warehouse-snapshot.sh: http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/load-test-warehouse-snapshot.sh@138 PS4, Line 138: hadoop fs -put ${SNAPSHOT_STAGING_DIR}${TEST_WAREHOUSE_DIR}/* ${FILESYSTEM_PREFIX}${TEST_WAREHOUSE_DIR} line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py File testdata/bin/rewrite-iceberg-metadata.py: http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@22 PS4, Line 22: import logging flake8: F401 'logging' imported but unused http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@36 PS4, Line 36: def add_prefix_to_snapshot(snapshot): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@43 PS4, Line 43: def add_prefix_to_mlog(metadata_log): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@47 PS4, Line 47: def add_prefix_to_snapshot_entry(entry): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@54 PS4, Line 54: for arg in args[1:]: flake8: E305 expected 2 blank lines after class or function definition, found 1 http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@80 PS4, Line 80: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@82 PS4, Line 82: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@90 PS4, Line 90: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/19001/4/testdata/bin/rewrite-iceberg-metadata.py@94 PS4, Line 94: + flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/19001/4/tests/metadata/test_explain.py File tests/metadata/test_explain.py: http://gerrit.cloudera.org:8080/#/c/19001/4/tests/metadata/test_explain.py@213 PS4, Line 213: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/19001/4/tests/util/hdfs_util.py File tests/util/hdfs_util.py: http://gerrit.cloudera.org:8080/#/c/19001/4/tests/util/hdfs_util.py@29 PS4, Line 29: from urlparse import urlparse flake8: F401 'urlparse.urlparse' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/19001 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45e90d30b2e68876dec0db3c43ac15ee510b17bd Gerrit-Change-Number: 19001 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 23 Sep 2022 17:59:27 +0000 Gerrit-HasComments: Yes
