Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18861 )
Change subject: IMPALA-11504:Specializing DecimalUtil::GetScaleMultiplier<int256_t>(). ...................................................................... Patch Set 3: (31 comments) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h File be/src/util/decimal-util.h: http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@311 PS3, Line 311: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 10000000000ll, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@312 PS3, Line 312: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 100000000000ll, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@313 PS3, Line 313: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000ll, line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@314 PS3, Line 314: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 10000000000000ll, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@315 PS3, Line 315: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 100000000000000ll, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@316 PS3, Line 316: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000ll, line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@317 PS3, Line 317: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 10000000000000000ll, line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@318 PS3, Line 318: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 100000000000000000ll, line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@319 PS3, Line 319: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll, line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@320 PS3, Line 320: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 10ll, line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@321 PS3, Line 321: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 100ll, line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@322 PS3, Line 322: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000ll, line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@323 PS3, Line 323: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 10000ll, line too long (109 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@324 PS3, Line 324: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 100000ll, line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@325 PS3, Line 325: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000ll, line too long (111 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@326 PS3, Line 326: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 10000000ll, line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@327 PS3, Line 327: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 100000000ll, line too long (113 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@328 PS3, Line 328: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000ll, line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@329 PS3, Line 329: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 10000000000ll, line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@330 PS3, Line 330: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 100000000000ll, line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@331 PS3, Line 331: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000ll, line too long (117 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@332 PS3, Line 332: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 10000000000000ll, line too long (118 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@333 PS3, Line 333: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 100000000000000ll, line too long (119 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@334 PS3, Line 334: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000000ll, line too long (120 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@335 PS3, Line 335: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 10000000000000000ll, line too long (121 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@336 PS3, Line 336: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 100000000000000000ll, line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@337 PS3, Line 337: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000000000ll, line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@338 PS3, Line 338: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000000000ll * 10ll, line too long (130 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@339 PS3, Line 339: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000000000ll * 100ll, line too long (131 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@340 PS3, Line 340: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000000000ll * 1000ll, line too long (132 > 90) http://gerrit.cloudera.org:8080/#/c/18861/3/be/src/util/decimal-util.h@341 PS3, Line 341: static_cast<int256_t>(1000000000000000000ll) * 1000000000000000000ll * 1000000000000000000ll * 1000000000000000000ll * 10000ll}; line too long (134 > 90) -- To view, visit http://gerrit.cloudera.org:8080/18861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I969e2977d51313e738f72c8246db003ae43a3782 Gerrit-Change-Number: 18861 Gerrit-PatchSet: 3 Gerrit-Owner: Xiang Yang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Sun, 25 Sep 2022 12:10:12 +0000 Gerrit-HasComments: Yes
