Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18958 )
Change subject: IMPALA-11563: Optimized /etc/sysconfig/clock to find the time zone ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18958/2//COMMIT_MSG@7 PS2, Line 7: Optimized This change is both an optimization (skipping # lines quickly) and potential fix,right? Can you add an example where this change leads to a different result? http://gerrit.cloudera.org:8080/#/c/18958/2/be/src/exprs/timezone_db.cc File be/src/exprs/timezone_db.cc: http://gerrit.cloudera.org:8080/#/c/18958/2/be/src/exprs/timezone_db.cc@183 PS2, Line 183: result.rfind("#", 0) == 0 Can you explain what does this mean? Based on https://cplusplus.com/reference/string/string/rfind/ the second argument of rfind means the last charecter to check, so 0 means that only the first character is checked. I think that result.size()>0 && result[0] == '#' would be easier to understand (thought it is longer) -- To view, visit http://gerrit.cloudera.org:8080/18958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f80fd1817d072f8dadf288025cb9534191ca458 Gerrit-Change-Number: 18958 Gerrit-PatchSet: 2 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jian Zhang <[email protected]> Gerrit-Comment-Date: Mon, 26 Sep 2022 14:07:10 +0000 Gerrit-HasComments: Yes
