Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19055 )
Change subject: IMPALA-3119: DDL support for bucketed tables ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/19055/5/common/thrift/CatalogObjects.thrift File common/thrift/CatalogObjects.thrift: http://gerrit.cloudera.org:8080/#/c/19055/5/common/thrift/CatalogObjects.thrift@196 PS5, Line 196: // When create bucketd table, need to know about bucket's type, bucket's columns and number. line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/19055/5/fe/src/main/java/org/apache/impala/analysis/TableDef.java File fe/src/main/java/org/apache/impala/analysis/TableDef.java: http://gerrit.cloudera.org:8080/#/c/19055/5/fe/src/main/java/org/apache/impala/analysis/TableDef.java@792 PS5, Line 792: if (bucketDesc.getBucket_columns() == null || bucketDesc.getBucket_columns().size() == 0) { line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/19055/5/fe/src/main/java/org/apache/impala/util/BucketUtils.java File fe/src/main/java/org/apache/impala/util/BucketUtils.java: http://gerrit.cloudera.org:8080/#/c/19055/5/fe/src/main/java/org/apache/impala/util/BucketUtils.java@40 PS5, Line 40: TBucketType bucketType = TBucketType.valueOf(params.get(Table.HIVE_IMPALA_BUCKET_TYPE)); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/19055 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I919b4d4139bc3a7784fa6fdb6f064e25666d548e Gerrit-Change-Number: 19055 Gerrit-PatchSet: 5 Gerrit-Owner: Baike Xia <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 04:29:10 +0000 Gerrit-HasComments: Yes
