Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 )
Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation ...................................................................... Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17640/5//COMMIT_MSG@29 PS5, Line 29: > Thanks Csaba! Prefixes provided in your example are supported. I will try t Were these tests added somewhere? Sorry if I have just missed them. http://gerrit.cloudera.org:8080/#/c/17640/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17640/6//COMMIT_MSG@7 PS6, Line 7: IMPALA-10436: Require lower privilege for external Kudu table creation To me the title suggests that creating external Kudu tables will simply need less privilege, while actually a new kind of privilege was added for this. Maybe a title like "Support storage handler privileges for external Kudu table creation" would be more descriptive. http://gerrit.cloudera.org:8080/#/c/17640/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/17640/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@406 PS5, Line 406: // Server is used by column, function, and URI resources. Can you update the comment? http://gerrit.cloudera.org:8080/#/c/17640/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerCatalogdAuthorizationManager.java@445 PS5, Line 445: } is it valid if we don't go to the if? http://gerrit.cloudera.org:8080/#/c/17640/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java File fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java: http://gerrit.cloudera.org:8080/#/c/17640/5/fe/src/main/java/org/apache/impala/authorization/ranger/RangerImpaladAuthorizationManager.java@325 PS5, Line 325: // Server is used by column, function, and URI resources. stale comment -- To view, visit http://gerrit.cloudera.org:8080/17640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7936e1d8c48696169f7ad7ad92abe44a26eea3c4 Gerrit-Change-Number: 17640 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 30 Sep 2022 15:29:17 +0000 Gerrit-HasComments: Yes
