Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19052 )
Change subject: IMPALA-8592: Add support for insert events for 'LOAD DATA' statements from Impala ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/19052/4/tests/metadata/test_event_processing.py File tests/metadata/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/19052/4/tests/metadata/test_event_processing.py@396 PS4, Line 396: parquet".format(unique_database, tbl_part)) Can we keep the wait of "EventProcessorUtils.wait_for_event_processing(self)"? I'm just concerning the test become flaky if the CREATE_TABLE events come late. http://gerrit.cloudera.org:8080/#/c/19052/4/tests/metadata/test_event_processing.py@408 PS4, Line 408: assert len(events) == 1 I think we need to mark this test using @pytest.mark.execute_serially. Otherwise, it runs concurrently with other metadata tests, which can be flaky as well. -- To view, visit http://gerrit.cloudera.org:8080/19052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f1b470f40e0aaf891c9f3f327af393b2f9c74bc Gerrit-Change-Number: 19052 Gerrit-PatchSet: 4 Gerrit-Owner: Yu-Wen Lai <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yu-Wen Lai <[email protected]> Gerrit-Comment-Date: Mon, 03 Oct 2022 23:17:17 +0000 Gerrit-HasComments: Yes
